This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Expose channel buffer resize and overflow calls #44434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @reidbaker for routing to a reviewer. There doesn't seem to be a motivating use case in the linked issue so that would be good to suss out too. |
|
FYI, I assigned Hixie and Jason as reviewers because:
|
|
Looks good to me but my Java is rusty, best to have someone more familiar with this code review it. |
2 tasks
johnmccutchan
approved these changes
Aug 14, 2023
bleroux
changed the title
|
May I land this? |
|
I'm so sorry. I misclicked closing this. |
bleroux
force-pushed
the
android_add_channel_buffer_utilities_resize_and_overflow
branch
from
50cb021 to
2cdd66a
Compare
reidbaker
approved these changes
Aug 17, 2023
bleroux
added
the
autosubmit
bleroux
deleted the
android_add_channel_buffer_utilities_resize_and_overflow
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 18, 2023
…132857) flutter/engine@58f7d8e...83fdada 2023-08-18 [email protected] Update Impeller benchmarks.md with a Pixel 7 link (flutter/engine#44834) 2023-08-18 [email protected] Roll Fuchsia Linux SDK from 7xOzci7fempFgHNk9... to pSqQ556xmZp7S4np5... (flutter/engine#44846) 2023-08-18 [email protected] Roll Dart SDK from 121fcbd8124c to 8109103e041b (1 revision) (flutter/engine#44844) 2023-08-18 [email protected] [Impeller] add trace events for VkRenderPass and VkFrameBuffer creation. (flutter/engine#44837) 2023-08-18 [email protected] Roll Fuchsia Mac SDK from Tnp43n_nAR2N0l_gY... to onEHyyETXAMieDyfP... (flutter/engine#44845) 2023-08-18 [email protected] Roll Skia from 1e62a2d4c429 to c9294edc03b9 (2 revisions) (flutter/engine#44843) 2023-08-18 [email protected] [Android] Expose channel buffer resize and overflow calls (flutter/engine#44434) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 7xOzci7fempF to pSqQ556xmZp7 fuchsia/sdk/core/mac-amd64 from Tnp43n_nAR2N to onEHyyETXAMi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
) ## Description This PR updates the Android engine in order to provide a more efficient implementation for `BasicMessageChannel.resizeChannelBuffer` (helper to call the `resize` control command). It also adds a new helper called`BasicMessageChannel.allowChannelBufferOverflow` to call the `overflow` control command. ## Related Issue Fixes flutter/flutter#132048 Android implementation for flutter/flutter#132386 ## Tests Adds 2 tests.
Closed
2 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
#44848) ## Description This PR update the helper function that invokes the control channel 'resize' command (previous implementation relied on a deprecated format). It also adds a similar helper function for the 'overflow' commands exposed by the control channel. See: https://github.com/flutter/engine/blob/93e8901490e78c7ba7e319cce4470d9c6478c6dc/lib/ui/channel_buffers.dart#L302-L309 ## Related Issue iOS and macOS implementation for flutter/flutter#132386 Similar implementations: - Android: #44434 - Linux: #44636 ## Tests Adds two tests.
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
#46361) ## Description This PR is a follow-up to #44434 which introduces the `allowChannelBufferOverflow` function. It renames this function to `setWarnsOnChannelOverflow`. The previous naming was inspired by the framework side implementation. https://github.com/flutter/engine/blob/93e8901490e78c7ba7e319cce4470d9c6478c6dc/lib/ui/channel_buffers.dart#L574 During the review of the iOS/macOS implementation, #44848 (comment), we agreed that the existing naming is confusing because it implies that overflow will be allowed, but this not the case this function is used to enable/disable error messages when a channel overflows. ## Related Issue Follow-up for flutter/flutter#132386. ## Tests Updates 1 test.
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
#44848) ## Description This PR update the helper function that invokes the control channel 'resize' command (previous implementation relied on a deprecated format). It also adds a similar helper function for the 'overflow' commands exposed by the control channel. See: https://github.com/flutter/engine/blob/93e8901490e78c7ba7e319cce4470d9c6478c6dc/lib/ui/channel_buffers.dart#L302-L309 ## Related Issue iOS and macOS implementation for flutter/flutter#132386 Similar implementations: - Android: #44434 - Linux: #44636 ## Tests Adds two tests.
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
#46361) ## Description This PR is a follow-up to #44434 which introduces the `allowChannelBufferOverflow` function. It renames this function to `setWarnsOnChannelOverflow`. The previous naming was inspired by the framework side implementation. https://github.com/flutter/engine/blob/93e8901490e78c7ba7e319cce4470d9c6478c6dc/lib/ui/channel_buffers.dart#L574 During the review of the iOS/macOS implementation, #44848 (comment), we agreed that the existing naming is confusing because it implies that overflow will be allowed, but this not the case this function is used to enable/disable error messages when a channel overflows. ## Related Issue Follow-up for flutter/flutter#132386. ## Tests Updates 1 test.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Android engine in order to provide a more efficient implementation for
BasicMessageChannel.resizeChannelBuffer(helper to call theresizecontrol command).It also adds a new helper called
BasicMessageChannel.allowChannelBufferOverflowto call theoverflowcontrol command.Related Issue
Fixes flutter/flutter#132048
Android implementation for flutter/flutter#132386
Tests
Adds 2 tests.